PARQUET-369: Add shaded SLF4J NOP binding. #32
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdblue
force-pushed
the
PARQUET-369-fix-slf4j-binding
branch
2 times, most recently
from
d30941a to
8ff5c80
Compare
rdblue
changed the title
This silences the complaint that no logger implementation could be found. No logger implementation was possible because the class that SLF4J was trying to load had been relocated. The only options are to relocate an implementation along with SLF4J or not shade SLF4J. This adds the NOP logger to silence the warning.
rdblue
force-pushed
the
PARQUET-369-fix-slf4j-binding
branch
from
8ff5c80 to
f993a91
Compare
Contributor
|
+1 Thanks for fixing this super annoying issue :) |
Contributor
Author
|
Thanks for reviewing! |
Contributor
Author
|
@julienledem could you take a look as well? Thanks! |
|
+1 Please merge this |
Contributor
Author
|
@isnotinvain or @julienledem can you take a look at this? |
Contributor
|
+1 |
Contributor
Author
|
Thanks for the reviews @almike, @isnotinvain, and @liancheng! |
Member
|
looks good. thanks |
Member
|
agreed that we'd want to remove the shading for slf4j. |
lekv
pushed a commit
to lekv/parquet-format
that referenced
this pull request
Jul 31, 2017
…litate unit testing Several things in this patch * Adds PageReader abstraction, and a SerializedPageReader implementation according to the Parquet file format * Adds a MockPageReader and a couple unit tests demonstrating end-to-end test without creating a Parquet file * Adds a DataPageBuilder test fixture tool, may become part of the main write path later * Adds PlainEncoder implementation for a few primitive types * Fixes a few ColumnReader bugs exposed by the unit tests Author: Wes McKinney <wes@cloudera.com> Closes apache#32 from wesm/PARQUET-485 and squashes the following commits: aa33078 [Wes McKinney] Fix function doc e897a81 [Wes McKinney] Restore NumRequiredBits function after rebase ee4d97a [Wes McKinney] Change PageReader::NextPage API to return shared_ptr<Page>(nullptr) on eos 0324021 [Wes McKinney] Clarify some comments ec871c4 [Wes McKinney] Add include guards e63bbdd [Wes McKinney] Move vector_equal to util/test-common.h 44a78a1 [Wes McKinney] Refactor to decouple page deserialization from column reader so that mock data pages cna be constructed in unit tests.
lekv
pushed a commit
to lekv/parquet-format
that referenced
this pull request
Jul 31, 2017
Requires PARQUET-485 (apache#32) The boolean Encoding::PLAIN code path was using RleDecoder, inconsistent with other implementations of Parquet. This patch adds an implementation of plain encoding and uses BitReader instead of RleDecoder to decode plain-encoded boolean data. Unit tests to verify. Also closes PR apache#12. Thanks to @edani for reporting. Author: Wes McKinney <wes@cloudera.com> Closes apache#34 from wesm/PARQUET-454 and squashes the following commits: 01cb5a7 [Wes McKinney] Use a seed in the data generation 0bf5d8a [Wes McKinney] Fix inconsistencies with boolean PLAIN encoding.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This silences the complaint that no logger implementation could be
found. No logger implementation was possible because the class that
SLF4J was trying to load had been relocated. The only options are to
relocate an implementation along with SLF4J or not shade SLF4J. This
adds the NOP logger to silence the warning.